HIVE-1637: Update installer vendor#1526
HIVE-1637: Update installer vendor#1526openshift-merge-robot merged 3 commits intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
approved
| pool: testOvirtPool(), | ||
| expectedMachineSetReplicas: map[string]int64{ | ||
| fmt.Sprintf("%s-worker-0", testInfraID): 3, | ||
| fmt.Sprintf("%s-worker", testInfraID): 3, |
There was a problem hiding this comment.
just so i understand , previously they had -0 suffix even when there was only on machineset for a machinepool, but they have replaced the name to no suffix. and our worry is that it will affect our existing clusters as they will now have a new machineset and abandon the last one?
There was a problem hiding this comment.
Yeah, my worry is that if the naming changes we will replace machinesets for existing ovirt clusters.
There was a problem hiding this comment.
Added a function to preserve the suffix.
Codecov Report
@@ Coverage Diff @@
## master #1526 +/- ##
==========================================
- Coverage 41.59% 41.59% -0.01%
==========================================
Files 336 336
Lines 30601 30619 +18
==========================================
+ Hits 12729 12735 +6
- Misses 16785 16797 +12
Partials 1087 1087
|
|
/retest |
|
/retest Most recent failures look like busted resume of CI pool clusters. |
|
/retest |
|
Trying out a rebase |
|
/test e2e |
1 similar comment
|
/test e2e |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, abutcher The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-pool |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-pool |
|
(#1534 should address the most recent flake) |
|
/test e2e-pool |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-pool |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 participants
/cc @abhinavdahiya